Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): hide handling cost if no cost associated #671

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

jorgemoya
Copy link
Contributor

What/Why?

No need to display if the cost is $0.

Handling cost shown below:
image

Testing

Locally.

@jorgemoya jorgemoya requested a review from a team as a code owner March 18, 2024 20:18
Copy link

changeset-bot bot commented Mar 18, 2024

🦋 Changeset detected

Latest commit: 9bd8ea9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2024 8:19pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Mar 18, 2024 8:19pm
catalyst-au ⬜️ Ignored (Inspect) Mar 18, 2024 8:19pm
catalyst-storybook ⬜️ Ignored (Inspect) Mar 18, 2024 8:19pm
catalyst-uk ⬜️ Ignored (Inspect) Mar 18, 2024 8:19pm

Copy link
Contributor

⚡️🏠 Lighthouse report

We ran Lighthouse against the changes and produced this report. Here's the summary:

Category Score
🟢 Performance 96
🟢 Accessibility 100
🟠 Best practices 78
🟢 SEO 92

Lighthouse ran against https://catalyst-latest-pxcieyjfl-bigcommerce-platform.vercel.app/

@jorgemoya jorgemoya added this pull request to the merge queue Mar 18, 2024
Merged via the queue into main with commit 9c5bb8c Mar 18, 2024
12 checks passed
@jorgemoya jorgemoya deleted the hide-shipping-cost branch March 18, 2024 22:56
@github-actions github-actions bot mentioned this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants