Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): use prefix flag to set cwd for schema generation #670

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

matthewvolk
Copy link
Contributor

What/Why?

exec option for cwd isn't working properly, and results in the following error when running the CLI:
GyNFvsqP

Using --prefix flag fixes this issue

Testing

Verdaccio, locally:
Screenshot 2024-03-18 at 2 06 14 PM

@matthewvolk matthewvolk requested a review from a team as a code owner March 18, 2024 19:06
Copy link

changeset-bot bot commented Mar 18, 2024

🦋 Changeset detected

Latest commit: ccd6e1c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/create-catalyst Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2024 7:09pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Mar 18, 2024 7:09pm
catalyst-au ⬜️ Ignored (Inspect) Mar 18, 2024 7:09pm
catalyst-storybook ⬜️ Ignored (Inspect) Mar 18, 2024 7:09pm
catalyst-uk ⬜️ Ignored (Inspect) Mar 18, 2024 7:09pm

Copy link
Contributor

⚡️🏠 Lighthouse report

We ran Lighthouse against the changes and produced this report. Here's the summary:

Category Score
🟢 Performance 95
🟢 Accessibility 100
🟠 Best practices 78
🟢 SEO 92

Lighthouse ran against https://catalyst-latest-uk4zvaalo-bigcommerce-platform.vercel.app/

@matthewvolk matthewvolk added this pull request to the merge queue Mar 18, 2024
Merged via the queue into main with commit efd6387 Mar 18, 2024
12 checks passed
@matthewvolk matthewvolk deleted the fix/schema-gen-prefix branch March 18, 2024 19:25
This was referenced Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants