feat(core): add components for change password #665
Conversation
🦋 Changeset detectedLatest commit: 8b7a497 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
bc-alexsaiannyi
force-pushed
the
change-password
branch
from
ec96096
to
4af4f6b
Compare
bc-alexsaiannyi
force-pushed
the
change-password
branch
from
4af4f6b
to
a15fcb1
Compare
| if (submit.status === 'failed') { | ||
| setFormStatus({ status: 'error', message: submit.error ?? '' }); | ||
| } |
There was a problem hiding this comment.
Should we just use the same status strings between the action and the component? What if submitChangePasswordForm returned status: 'error' when an error occurred? It could potentially simplify this 🙂
There was a problem hiding this comment.
Good point, Matt. I've refactored it already
| newPassword: z.string().min(7), | ||
| confirmPassword: z.string().min(7), |
There was a problem hiding this comment.
Should min length be taken from password fields settings via GQL?
bc-alexsaiannyi
force-pushed
the
change-password
branch
from
98e4a60
to
841ffc1
Compare
⚡️🏠 Lighthouse reportWe ran Lighthouse against the changes and produced this report. Here's the summary:
Lighthouse ran against https://catalyst-latest-qm1f12yp1-bigcommerce-platform.vercel.app/ |
What/Why?
This PR adds second step for changing password.
Testing
locally