fix(core): use amount and discounts fields for cart summary #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8bef691 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
|
It looks like the Grand Total in your screenshot isn't taking into account the discounts, is that correct? |
jorgemoya
force-pushed
the
fix-discounts-cart
branch
from
df1989c
to
5da9820
Compare
jorgemoya
force-pushed
the
fix-discounts-cart
branch
from
5da9820
to
dd05327
Compare
jorgemoya
force-pushed
the
fix-discounts-cart
branch
from
f0e03ee
to
42d3567
Compare
jorgemoya
changed the title
⚡️🏠 Lighthouse reportWe ran Lighthouse against the changes and produced this report. Here's the summary:
Lighthouse ran against https://catalyst-latest-6zkpx78l1-bigcommerce-platform.vercel.app/ |
deini
approved these changes
Mar 15, 2024
Fixed by using |
This was referenced Mar 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
Discount was not showing in cart for a marketing promotion. Noticed we were using the
discountedAmountfor each specific line item instead of the global discounted amount value.Testing
Locally