Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): create graphql schema using gql.tada #658

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

matthewvolk
Copy link
Contributor

@matthewvolk matthewvolk commented Mar 14, 2024

Updates from @deini: Did all the listed changes and a few others, this PR is now ready for review.

What/Why?

⚠️ Depends on 0no-co/gql.tada#137

Once the PR above is merged, and @gql.tada/cli-utils@0.2.0 is available via npm, this PR needs the following changes:

  • Bump @gql.tada/cli-utils in apps/core to ^0.2.0
  • Commit changes and push to this branch
  • Run pnpm build for packages/create-catalyst locally
  • Test the CLI locally: node ~/path/to/your/catalyst/packages/create-catalyst/dist/index.js --package-manager pnpm --gh-ref feat/gen-schema-gqltada

When that script runs, it should complete successfully, and you should be able to open the new my-catalyst-app directory and see:

  • schema.graphql file created (created by the CLI running pnpm run generate in apps/core)
  • graphql-env.d.ts file created (created by the CLI running pnpm run generate in apps/core)
  • client/generated should have types successfully generated

Testing

See above

Copy link

changeset-bot bot commented Mar 14, 2024

🦋 Changeset detected

Latest commit: 956b09f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@bigcommerce/create-catalyst Minor
@bigcommerce/catalyst-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 15, 2024 4:25pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Mar 15, 2024 4:25pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Mar 15, 2024 4:25pm
catalyst-storybook ⬜️ Ignored (Inspect) Visit Preview Mar 15, 2024 4:25pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Mar 15, 2024 4:25pm

Copy link
Contributor

⚡️🏠 Lighthouse report

We ran Lighthouse against the changes and produced this report. Here's the summary:

Category Score
🟢 Performance 97
🟢 Accessibility 100
🟠 Best practices 78
🟢 SEO 92

Lighthouse ran against https://catalyst-latest-ja3bxnyea-bigcommerce-platform.vercel.app/

@deini deini added this pull request to the merge queue Mar 15, 2024
Merged via the queue into main with commit 8ff2eb6 Mar 15, 2024
12 checks passed
@deini deini deleted the feat/gen-schema-gqltada branch March 15, 2024 16:56
This was referenced Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants