-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): monorepo changes required to run create-catalyst
CLI
#457
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
39fd2d4
to
4a92445
Compare
4a92445
to
b240fb1
Compare
apps/docs/vite.config.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this, building storybook crashes with an error:
Error: [vite]: Rollup failed to resolve import "~/lib/utils" from "catalyst/packages/reactant/src/components/Input/Input.tsx".
b240fb1
to
6b0ea13
Compare
6b0ea13
to
d082955
Compare
d082955
to
05b497b
Compare
⚡️🏠 Lighthouse reportWe ran Lighthouse against the changes and produced this report. Here's the summary:
Lighthouse ran against https://catalyst-rnz602pym-bigcommerce-platform.vercel.app/ |
What/Why?
cn
in Reactant must be throughtsconfig
paths. This allows components to be copied over intoapps/core
without needing to modifycn
references.dotenv-cli
toapps/core
so thatcodegen
anddev-codegen
package scripts can be run outside of the monorepo.tsconfig
path inapps/core
to map references to@bigcommerce/reactant/*
to./node_modules/@bigcommerce/reactant/*
. When thecreate-catalyst
CLI creates the new projecttsconfig
, this path is mapped to./components/ui/*
where the Reactant components are copied into.tsconfig
path inpackages/reactant
to allow references tocn
insidepackages/reactant
to be the same as references tocn
from withinapps/core
.apps/core/userAgent.ts
cannot reference monorepopackage.json
outside of the monorepo.packages/reactant/.eslintrc.cjs
andapps/core/.eslintrc.cjs
so that we can have a single.eslintrc.cjs
to use while Catalyst is running outside of the monorepo.packages/reactant/tailwind.config.js
andapps/core/tailwind.config.js
so that we can have a singletailwind.config.js
to use while Catalyst is running outside of the monorepo.Testing
https://bigcommerce.slack.com/archives/C056HLZC36W/p1706286802069659?thread_ts=1706213429.702309&cid=C056HLZC36W