Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): remove duplicate queries that are not used #1349

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

jorgemoya
Copy link
Contributor

What/Why?

Removes previously removed queries since we no longer define them inside client.

Testing

Locally.

@jorgemoya jorgemoya requested a review from a team as a code owner September 6, 2024 19:23
Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 7:24pm
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Sep 6, 2024 7:24pm
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Sep 6, 2024 7:24pm
catalyst-au ⬜️ Ignored (Inspect) Sep 6, 2024 7:24pm
catalyst-staging ⬜️ Ignored (Inspect) Sep 6, 2024 7:24pm
catalyst-test-store ⬜️ Ignored (Inspect) Sep 6, 2024 7:24pm
catalyst-uk ⬜️ Ignored (Inspect) Sep 6, 2024 7:24pm
catalyst-unstable ⬜️ Ignored (Inspect) Sep 6, 2024 7:24pm

Copy link

changeset-bot bot commented Sep 6, 2024

🦋 Changeset detected

Latest commit: fb87080

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jorgemoya jorgemoya added this pull request to the merge queue Sep 6, 2024
Merged via the queue into main with commit dd9cf6f Sep 6, 2024
13 of 14 checks passed
@jorgemoya jorgemoya deleted the remove-unused-queries branch September 6, 2024 19:29
Copy link
Contributor

github-actions bot commented Sep 6, 2024

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-a853c1e91-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 87
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 92
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants