-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): localization #1316
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
🦋 Changeset detectedLatest commit: dd0eeb7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@bc-andreadao For this PR I updated the docs to better showcase the simplified use of translations. Please let me know if you have any feedback. Thanks! |
ℹ️ Hide whitespace changes helps with review |
Thanks @jorgemoya ! |
65d89ba
to
4020d34
Compare
4020d34
to
e529a7b
Compare
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-91c645lrj-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
Note: Review by commit if needed & remove white spaces.
What/Why?
The PR addresses missing translations on some pages and aims to normalize how translations are handled throughout the project.
Configuration Changes
next-intl
version and adjusted the configuration accordingly.navigation.ts
torouting.ts
for consistency with documentation.defineRouting
function.NextIntlClientProvider
in RootLayout to pass all messages, making the use ofnext-intl
hooks in client components easier.useTranslations
in both client and server components without async functions.await getTranslations
in server components with async functions.formatter
.locale
to these hooks (not needed).Translations
components/ui
.Components
root group for better organization.Docs
Testing
Locally translations work.