Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decode Webpage id to fix 404 on Webpages with nonsafe ids (#1301) #1302

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

deini
Copy link
Member

@deini deini commented Aug 22, 2024

OSS contribution from: #1301

* Fix: Decode Webpage Id to fix 404 on Webpages with nonsafe ids

* chore: add changeset

---------

Co-authored-by: Onur Yanar <onur4185@google.com>
Co-authored-by: Daniel Almaguer <daniel.almaguer@bigcommerce.com>
@deini deini requested a review from a team as a code owner August 22, 2024 18:21
Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 6:22pm
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Aug 22, 2024 6:22pm
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Aug 22, 2024 6:22pm
catalyst-au ⬜️ Ignored (Inspect) Aug 22, 2024 6:22pm
catalyst-staging ⬜️ Ignored (Inspect) Aug 22, 2024 6:22pm
catalyst-test-store ⬜️ Ignored (Inspect) Aug 22, 2024 6:22pm
catalyst-uk ⬜️ Ignored (Inspect) Aug 22, 2024 6:22pm
catalyst-unstable ⬜️ Ignored (Inspect) Aug 22, 2024 6:22pm

Copy link

changeset-bot bot commented Aug 22, 2024

🦋 Changeset detected

Latest commit: 4ed5c20

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@deini deini added this pull request to the merge queue Aug 22, 2024
Merged via the queue into main with commit a620a19 Aug 22, 2024
14 checks passed
@deini deini deleted the contributions branch August 22, 2024 18:40
@github-actions github-actions bot mentioned this pull request Aug 22, 2024
Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-hvcq0qmjq-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 80
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 96
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants