Add dynamic favicon from API #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Skipped Deployments
|
🦋 Changeset detectedLatest commit: 25c0324 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
chanceaclark
approved these changes
Aug 17, 2024
chanceaclark
approved these changes
Aug 19, 2024
jorgemoya
approved these changes
Aug 20, 2024
Closed
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-dl26i8ccb-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
Uses new favicon node in GraphQL Storefront API to return the store's favicon dynamically. The API will always return something; if there's no favicon, it defaults to the BC logo.
I made this a static route because favicons change so infrequently, but this does mean you need to rebuild the app to see an updated favicon.
Rather than returning a
<link>to our CDN, I'm proxying the image data and serving it directly; this is faster.Putting
do not mergeon this until the new GraphQL node is fully rolled out.Note: I tried to follow the pattern here and do this in an
icon.tsfile, but it didn't work for some reason.Testing
Preview deployment:
