Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): parse env using dotenv #1240

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

matthewvolk
Copy link
Contributor

What/Why?

Parse environment variable diff using dotenv.parse instead of custom regex expression

Testing

pnpm dev && node ./packages/create-catalyst/dist/index.js integration name

@matthewvolk matthewvolk requested a review from a team as a code owner August 7, 2024 21:25
Copy link

changeset-bot bot commented Aug 7, 2024

🦋 Changeset detected

Latest commit: b3cc58d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/create-catalyst Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Aug 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 7:19pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Aug 8, 2024 7:19pm
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Aug 8, 2024 7:19pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Aug 8, 2024 7:19pm
catalyst-test-store ⬜️ Ignored (Inspect) Visit Preview Aug 8, 2024 7:19pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Aug 8, 2024 7:19pm
catalyst-unstable ⬜️ Ignored (Inspect) Visit Preview Aug 8, 2024 7:19pm

Copy link
Contributor

github-actions bot commented Aug 8, 2024

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-ebjcmdth2-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 95
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 92
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85

@matthewvolk matthewvolk added this pull request to the merge queue Aug 8, 2024
Merged via the queue into main with commit dc2cc0d Aug 8, 2024
13 checks passed
@matthewvolk matthewvolk deleted the refactor/env-parse branch August 8, 2024 19:24
@github-actions github-actions bot mentioned this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants