-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up builds by excluding node_modules from tailwind config #1236
Conversation
🦋 Changeset detectedLatest commit: ed371e0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
2a430f7
to
ed371e0
Compare
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-q16lo7wbf-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
content: [ | ||
'./app/**/*.{ts,tsx}', | ||
'./components/**/*.{ts,tsx}', | ||
'!./node_modules/**', // Exclude everything in node_modules to speed up builds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, do you know why this happens? I don't understand why we have to exclude a path we aren't including. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish I knew!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it's expected: tailwindlabs/tailwindcss#5014 (comment)
What/Why?
vercel/next.js#37825 (comment)
Our build time was spending over 60 seconds on
Creating an optimized production build...
so I tried removing thenode_modules
folder from thecontent
in tailwind config, and I see much faster build times now.Testing
Preview build
Before:
After: