Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): change value prop to rating in Rating #1226

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

jorgemoya
Copy link
Contributor

What/Why?

We only need a rating and size prop.

Testing

Locally it all looks the same.

@jorgemoya jorgemoya requested a review from a team as a code owner August 5, 2024 19:50
Copy link

vercel bot commented Aug 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2024 7:50pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Aug 5, 2024 7:50pm
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Aug 5, 2024 7:50pm
catalyst-au ⬜️ Ignored (Inspect) Aug 5, 2024 7:50pm
catalyst-test-store ⬜️ Ignored (Inspect) Aug 5, 2024 7:50pm
catalyst-uk ⬜️ Ignored (Inspect) Aug 5, 2024 7:50pm
catalyst-unstable ⬜️ Ignored (Inspect) Aug 5, 2024 7:50pm

Copy link

changeset-bot bot commented Aug 5, 2024

🦋 Changeset detected

Latest commit: d0bcc6c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jorgemoya jorgemoya added this pull request to the merge queue Aug 5, 2024
Merged via the queue into main with commit d6d1224 Aug 5, 2024
13 checks passed
@jorgemoya jorgemoya deleted the rating-refactor-props branch August 5, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants