Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove title prop from Tabs #1190

Merged
merged 2 commits into from
Jul 31, 2024
Merged

feat: remove title prop from Tabs #1190

merged 2 commits into from
Jul 31, 2024

Conversation

jorgemoya
Copy link
Contributor

What/Why?

  • Remove title prop from Tabs.
  • Remove use of Tabs in /account since it's not really a Tab component, but a set of links.
  • Removed test since we don't have a current implementation of Tabs yet.

Testing

Locally.

@jorgemoya jorgemoya requested a review from a team as a code owner July 30, 2024 19:23
Copy link

changeset-bot bot commented Jul 30, 2024

🦋 Changeset detected

Latest commit: c83f543

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jul 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 8:21pm
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 8:21pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Jul 30, 2024 8:21pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Jul 30, 2024 8:21pm
catalyst-test-store ⬜️ Ignored (Inspect) Visit Preview Jul 30, 2024 8:21pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Jul 30, 2024 8:21pm
catalyst-unstable ⬜️ Ignored (Inspect) Visit Preview Jul 30, 2024 8:21pm

@jorgemoya
Copy link
Contributor Author

Made a change in how we set the Tab title from translations.

Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-bv6ysx526-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 99
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 90
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85

@jorgemoya jorgemoya added this pull request to the merge queue Jul 31, 2024
Merged via the queue into main with commit d01b4e0 Jul 31, 2024
13 checks passed
@jorgemoya jorgemoya deleted the fix-tabs-props branch July 31, 2024 03:26
This was referenced Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants