Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEO improvements #1166

Merged
merged 4 commits into from
Aug 5, 2024
Merged

SEO improvements #1166

merged 4 commits into from
Aug 5, 2024

Conversation

bookernath
Copy link
Contributor

@bookernath bookernath commented Jul 28, 2024

What/Why?

  • Take advantage of the new seo field on site.settings to set default metadata on the layout level. This metadata will be used, if specified in the channel settings, to set the page title, meta description, and meta keywords on any pages that do not specify more specific values.
  • Normalize/standardize how we set up SEO metadata across page entity types for consistency
  • Fix a bug where generateMetadata was not exported on our static pages for categories and brands

Testing

Manually/locally tested different scenarios with/without store settings and page-local settings.

@bookernath bookernath requested a review from a team as a code owner July 28, 2024 16:07
Copy link

changeset-bot bot commented Jul 28, 2024

🦋 Changeset detected

Latest commit: c4f99e0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jul 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview Aug 5, 2024 6:47pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Aug 5, 2024 6:47pm
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Aug 5, 2024 6:47pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Aug 5, 2024 6:47pm
catalyst-test-store ⬜️ Ignored (Inspect) Visit Preview Aug 5, 2024 6:47pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Aug 5, 2024 6:47pm
catalyst-unstable ⬜️ Ignored (Inspect) Visit Preview Aug 5, 2024 6:47pm


return {
title: {
template: `${title} - %s`,
default: title,
template: `%s - ${storeName}`,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intentional stylistic change here - page first, store name second (same thing we do on stencil)

@bookernath bookernath added this pull request to the merge queue Jul 29, 2024
@bookernath bookernath removed this pull request from the merge queue due to a manual request Jul 29, 2024
@bookernath
Copy link
Contributor Author

This should not be merged until the SEO node is rolled out to all stores.

Copy link
Contributor

github-actions bot commented Aug 2, 2024

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-m5xfb2ebt-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 82
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 79
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85

@bookernath bookernath added this pull request to the merge queue Aug 5, 2024
Merged via the queue into main with commit 0661e53 Aug 5, 2024
9 of 10 checks passed
@bookernath bookernath deleted the seo-layout branch August 5, 2024 18:45
@github-actions github-actions bot mentioned this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants