fix(core): improve redirect behavior after creating new address #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 471cb9a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Skipped Deployments
|
bc-yevhenii-buliuk
force-pushed
the
fix-create-address-redirect
branch
from
7d9b34e
to
b34a51e
Compare
bc-yevhenii-buliuk
force-pushed
the
fix-create-address-redirect
branch
from
b34a51e
to
2072d09
Compare
bc-yevhenii-buliuk
force-pushed
the
fix-create-address-redirect
branch
2 times, most recently
from
edfafe6
to
637a4f3
Compare
bc-yevhenii-buliuk
force-pushed
the
fix-create-address-redirect
branch
from
637a4f3
to
27f9083
Compare
jorgemoya
approved these changes
Jul 24, 2024
yurytut1993
approved these changes
Jul 24, 2024
bc-azvierieva
requested changes
Jul 25, 2024
bc-yevhenii-buliuk
force-pushed
the
fix-create-address-redirect
branch
2 times, most recently
from
12b4d3e
to
fa318d1
Compare
bc-yevhenii-buliuk
force-pushed
the
fix-create-address-redirect
branch
from
fa318d1
to
6c554e9
Compare
|
Can we rebase and try to get this PR merged? |
@jorgemoya for this PR I need to add some small edits after testing. I'll deal with this as soon as possible. |
bc-yevhenii-buliuk
force-pushed
the
fix-create-address-redirect
branch
from
053bca9
to
471cb9a
Compare
Merged
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-q6we39avv-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
This PR improves redirect behavior after adding a new address, namely, it adds a banner about the successful creation of a new address.
Testing
locally
before:
create-address-redirect.mov
after:
fix-create-address-redirect.mov