Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add minor changes to address form layout #1086

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

bc-alexsaiannyi
Copy link
Contributor

What/Why?

The PR adds changes to address form layout like:

  • gap between form elements reduced to gap-y-3
  • removing top margin on heading;

Testing

locally

Screenshot 2024-07-11 at 14 39 26 Screenshot 2024-07-11 at 14 40 33

@bc-alexsaiannyi bc-alexsaiannyi requested a review from a team as a code owner July 11, 2024 15:55
Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 8:07am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Jul 15, 2024 8:07am
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 8:07am
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 8:07am
catalyst-test-store ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 8:07am
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 8:07am
catalyst-unstable ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 8:07am

Copy link

changeset-bot bot commented Jul 11, 2024

🦋 Changeset detected

Latest commit: af76b31

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-7jd6z6o90-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 96
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85

@bc-alexsaiannyi bc-alexsaiannyi added this pull request to the merge queue Jul 15, 2024
Merged via the queue into main with commit e0926ee Jul 15, 2024
12 of 13 checks passed
@bc-alexsaiannyi bc-alexsaiannyi deleted the update-address-forms-layout branch July 15, 2024 08:13
@github-actions github-actions bot mentioned this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants