Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use system environment variables for robots #1077

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

chanceaclark
Copy link
Contributor

@chanceaclark chanceaclark commented Jul 9, 2024

What/Why?

Uses the deployment URL for robots.txt.

Testing

https://catalyst-latest-git-fix-robots-bigcommerce-platform.vercel.app/robots.txt

Screenshot 2024-07-09 at 17 09 52

Copy link

vercel bot commented Jul 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 9:30pm
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 9:30pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Jul 9, 2024 9:30pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Jul 9, 2024 9:30pm
catalyst-test-store ⬜️ Ignored (Inspect) Visit Preview Jul 9, 2024 9:30pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Jul 9, 2024 9:30pm
catalyst-unstable ⬜️ Ignored (Inspect) Visit Preview Jul 9, 2024 9:30pm

Copy link

changeset-bot bot commented Jul 9, 2024

🦋 Changeset detected

Latest commit: 377d8ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

},
],
};
export function parseUrl(url?: string): URL {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to export this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

Copy link
Contributor

github-actions bot commented Jul 9, 2024

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-326v6rgkk-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 87
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 91
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85

@chanceaclark chanceaclark added this pull request to the merge queue Jul 9, 2024
Merged via the queue into main with commit e86f46f Jul 9, 2024
13 checks passed
@chanceaclark chanceaclark deleted the fix/robots branch July 9, 2024 23:15
@github-actions github-actions bot mentioned this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants