feat(core): add store selector page and link in footer #1034
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
🦋 Changeset detectedLatest commit: da8b3e9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| <FooterSection className="flex flex-col gap-10 sm:gap-8 sm:py-6 lg:hidden"> | ||
| <Locale /> | ||
|
|
||
| <div className="flex w-full flex-col justify-between gap-10 sm:flex-row sm:gap-8"> | ||
| <PaymentMethods /> | ||
| {data.settings && <Copyright data={data.settings} />} | ||
| </div> | ||
| </FooterSection> | ||
|
|
||
| <FooterSection className="hidden justify-between gap-8 py-6 lg:flex"> | ||
| {data.settings && <Copyright data={data.settings} />} | ||
| <div className="flex gap-8"> | ||
| <Locale /> | ||
| <PaymentMethods /> | ||
| </div> |
There was a problem hiding this comment.
Design between mobile/tablet vs desktop differ enough to warrant repeating code imo.
core/components/footer/locale.tsx
Outdated
| <Link className="flex gap-2" href="/store-selector"> | ||
| <Globe /> {locale.toUpperCase()} | ||
| </Link> |
There was a problem hiding this comment.
Will change in different PR.
jorgemoya
force-pushed
the
store-selector
branch
from
0be98b4
to
d35c2ad
Compare
jorgemoya
force-pushed
the
store-selector
branch
from
c8d80f5
to
ab07801
Compare
jorgemoya
force-pushed
the
store-selector
branch
from
d10e7ca
to
2729141
Compare
| // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition | ||
| locales.length > 1 && ( |
There was a problem hiding this comment.
Want to hide this link if there is only one locale, unfortunately had to prevent this rule from applying because when it is only one locale typescript doesn't see the need for this conditional.
| // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition | ||
| <LocaleLink key={locale} locale={locale} selected={selectedLocale === locale} /> |
There was a problem hiding this comment.
Similar issue here, unfortunately had to prevent this rule from applying because when it is only one locale typescript doesn't see the need for this conditional since selectedLocale can only match the current locale.
|
Found an issue with kv store when swapping locales, reverting to draft to fix this. |
|
Ready for re-review @bigcommerce/team-catalyst |
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-j9g9mpgyd-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
What/Why?
/store-selectorKnown issues
Testing
Go to
/store-selectorand switch locales.Screenshot