chore(core): standardize mutations by returning drilled response (#814)

.changeset/great-eagles-double.md

@@ -0,0 +1,5 @@
+---
+"@bigcommerce/catalyst-core": patch
+---
+
+standardize mutations by returning drilled response

apps/core/app/[locale]/(default)/login/_actions/submit-change-password-form.ts

@@ -27,13 +27,13 @@ export const submitChangePasswordForm = async (_previousState: unknown, formData
       customerEntityId: Number(parsedData.customerId),
     });
 
-    if (response.customer.resetPassword.errors.length === 0) {
+    if (response.errors.length === 0) {
       return { status: 'success', message: '' };
     }
 
     return {
       status: 'error',
-      message: response.customer.resetPassword.errors.map((error) => error.message).join('\n'),
+      message: response.errors.map((error) => error.message).join('\n'),
     };
   } catch (error: unknown) {
     if (error instanceof ZodError) {

apps/core/app/[locale]/(default)/login/_actions/submit-reset-password-form.ts

@@ -26,13 +26,13 @@ export const submitResetPasswordForm = async ({
       reCaptchaToken,
     });
 
-    if (response.customer.requestResetPassword.errors.length === 0) {
+    if (response.errors.length === 0) {
       return { status: 'success', data: parsedData };
     }
 
     return {
       status: 'error',
-      error: response.customer.requestResetPassword.errors.map((error) => error.message).join('\n'),
+      error: response.errors.map((error) => error.message).join('\n'),
     };
   } catch (error: unknown) {
     if (error instanceof Error || error instanceof z.ZodError) {

apps/core/app/[locale]/(default)/webpages/contact/[id]/contact-us/_actions/submit-contact-form.ts

@@ -35,13 +35,13 @@ export const submitContactForm = async ({
       reCaptchaToken,
     });
 
-    if (response.submitContactUs.errors.length === 0) {
+    if (response.errors.length === 0) {
       return { status: 'success', data: parsedData };
     }
 
     return {
       status: 'failed',
-      error: response.submitContactUs.errors.map((error) => error.message).join('\n'),
+      error: response.errors.map((error) => error.message).join('\n'),
     };
   } catch (e: unknown) {
     if (e instanceof Error || e instanceof z.ZodError) {

apps/core/client/mutations/add-checkout-shipping-consignments.ts

@@ -67,11 +67,5 @@ export const addCheckoutShippingConsignments = async ({
     fetchOptions: { cache: 'no-store' },
   });
 
-  const checkout = response.data.checkout.addCheckoutShippingConsignments?.checkout;
-
-  if (checkout) {
-    return checkout;
-  }
-
-  throw new Error('Something went wrong adding shipping info.');
+  return response.data.checkout.addCheckoutShippingConsignments?.checkout;
 };

apps/core/client/mutations/delete-customer-address.ts

@@ -43,5 +43,5 @@ export const deleteCustomerAddress = async (addressId: AddressId, reCaptchaToken
     },
   });
 
-  return response.data;
+  return response.data.customer.deleteCustomerAddress;
 };

apps/core/client/mutations/select-checkout-shipping-option.ts

@@ -41,11 +41,5 @@ export const selectCheckoutShippingOption = async ({
     fetchOptions: { cache: 'no-store' },
   });
 
-  const shippingCosts = response.data.checkout.selectCheckoutShippingOption?.checkout;
-
-  if (shippingCosts) {
-    return shippingCosts;
-  }
-
-  return null;
+  return response.data.checkout.selectCheckoutShippingOption?.checkout;
 };

apps/core/client/mutations/submit-change-password.ts

@@ -52,5 +52,5 @@ export const submitChangePassword = async ({
     variables,
   });
 
-  return response.data;
+  return response.data.customer.resetPassword;
 };

apps/core/client/mutations/submit-contact-form.ts

@@ -51,5 +51,5 @@ export const submitContactForm = async ({
     variables,
   });
 
-  return response.data;
+  return response.data.submitContactUs;
 };

apps/core/client/mutations/submit-reset-password.ts

@@ -42,5 +42,5 @@ export const submitResetPassword = async ({ email, path, reCaptchaToken }: Submi
     variables,
   });
 
-  return response.data;
+  return response.data.customer.requestResetPassword;
 };

apps/core/client/mutations/update-checkout-shipping-consigment.ts

@@ -68,11 +68,5 @@ export const updateCheckoutShippingConsignment = async ({
     fetchOptions: { cache: 'no-store' },
   });
 
-  const checkout = response.data.checkout.updateCheckoutShippingConsignment?.checkout;
-
-  if (checkout) {
-    return checkout;
-  }
-
-  return null;
+  return response.data.checkout.updateCheckoutShippingConsignment?.checkout;
 };