Domain renew ensures the expiration date is the date from the renew response #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / Why
When a domain is renewed, find requests on that domain are not guaranteed to reflect the expiration date. Now, when a domain is renewed, the found domain will have its expiration date updated to be the value of the previously successful extend command response.
Also,
lib/enom/domain.rb
has a dependency on ActiveSupportspresent?
method. Adding ActiveSupport as a dependency in the gemspec (I'm guessing on the version number here; we could probably go lower but that isn't necessary for our use case).How to test
Unit tests were updated to ensure the returned domain has an expiration date that is greater than the original expiration date.
I also tested manually by:
Log on to resellertest.enom.com with Login ID resellid, password resellpw. Find a domain to renew. Note this domain name as you'll need to paste the value in the next step.
Create a file at
_project_root_/console.rb
with the contents:Verify the domain's expiration date after the renew is different than the date in the original find request.
Also, after refreshing the domain page in eNom a few times, the new date should be reflected.