Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[77] Move no theme.json file found error message so it displays correctly. #78

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

jordanharris-6
Copy link
Contributor

@jordanharris-6 jordanharris-6 commented Jul 23, 2024

77 - This PR moves the ThemerNotice component into a position so that it shows when no theme.json file is found.

Change Log

  • Adds a new if statement to check for the theme.json file
  • Removes checks from the last return statement as these are done further up now.

Steps to test

Go to the style editor and check themer works
Remove or rename theme.json in the theme folder
Refresh the page
The error cannot read the file "theme.json" should show

Screenshots/Videos

http://bigbite.im/v/vg2HSM

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@g-elwell g-elwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks for looking into this one!

@g-elwell g-elwell merged commit f796c9a into release/1.0.0 Jul 23, 2024
1 check passed
This was referenced Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants