Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[BBT-110] Remove string handling in spacing styles component" #43

Merged

Conversation

g-elwell
Copy link
Member

Reverts #38

More back and forth on this one - once the fix was removed I seem to have hit this issue again.

It appears to be coming from the button element styles on my install. They are defined as follows in the TT3 theme:

"spacing": {
	"padding": {
		"top": "min(1rem, 3vw) !important",
		"right": "min(2.75rem, 6vw) !important",
		"bottom": "min(1rem, 3vw) !important",
		"left": "min(2.75rem, 6vw) !important"
	}
}

However they are showing up in the application as:

{padding: 'calc(0.667em + 2px) calc(1.333em + 2px)'}

Unsure how/when the styles are implemented, but I have confirmed they are present in the base config pulled from __experimentalGetCurrentThemeBaseGlobalStyles. Using WordPress 6.4.

Reverting this to add the safeguard back in for now until we can investigate a proper fix.

@g-elwell g-elwell marked this pull request as ready for review November 20, 2023 15:07
@g-elwell g-elwell merged commit 5e1f4cc into release/1.0.0 Nov 20, 2023
1 check passed
@g-elwell g-elwell mentioned this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant