[BBT-109] Conditionally render summary content #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds conditional rendering to the native
<summary>
HTML component which is being used to render block styles UI elements.Fixes BBT-109
When using an uncontrolled HTML summary element, React will render all child content whether or not it is visible to the user. When a significant number of components are added to the tree (which is the case if we render style UI for every possible element within every block), performance will drop significantly.
To fix this, we can convert the summary element to be controlled by React, keeping it's open value in state and conditionally rendering it's content based on whether or not it is open.
Change Log
Steps to test
This bug was discovered when experimenting with rendering nested element styles UI within blocks, which results in almost 2000 components being rendered at once. To partially replicate this performance impact, we can copy/paste the styles components within
BlocksItem
several times. The more components present, the worse the performance will become. Then:Screenshots/Videos
Before - http://bigbite.im/v/EQ8KRW
After - http://bigbite.im/v/NE1E0n
Checklist: