Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Use wp-scripts BBT-37 #2

Merged
merged 8 commits into from
Jun 23, 2023
Merged

Conversation

g-elwell
Copy link
Member

@g-elwell g-elwell commented Jun 22, 2023

What's changed?

This PR updates the local development setup to utilise @wordpress/scripts in place of the Big Bite build tools.

Fixes BBT-37

This change also allowed us to migrate the remaining WordPress dependencies to module imports rather than relying on accessing the global wp namespace.

Change log:

  • Removed @bigbite/build-tools and related npm scripts
  • Installed @wordpress/scripts and added relevant npm scripts
  • Moved script entrypoint to the default location expected by wp-scripts (/src/index.js)
  • Updated asset enqueuing to utilise wp-scripts generated asset files
  • Updated wp global imports to module imports
  • Switched inaccessible <CanvasSpinner> to <Spinner> from @wordpress/components
  • Removed any build-tools specific files and code
  • Updated prettier config to point to WordPress standards
  • Removed some unused files from the plugin

How has this been tested?

This has been tested locally to ensure that both the watch:dev and build:prod commands produce the required built asset files, and that these files are enqueued successfully in the editor.

Functionality has been checked to ensure that it remains the same as prior to this change.

The readme has been updated to ensure it reflects the updated build process.

@g-elwell g-elwell changed the title Feat/bbt 37 use wp scripts Feature: Use wp-scripts BBT-37 Jun 22, 2023
Copy link
Contributor

@chrishbite chrishbite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small change, everything else looks good 👍

README.md Outdated Show resolved Hide resolved
@g-elwell g-elwell changed the base branch from main to release/1.0.0 June 22, 2023 16:21
@g-elwell g-elwell requested a review from chrishbite June 22, 2023 16:37
@g-elwell g-elwell merged commit 1408f5b into release/1.0.0 Jun 23, 2023
@g-elwell g-elwell mentioned this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants