BBT-7 Convert css vars to hex value #14
Conversation
There was a problem hiding this comment.
Made a few comments, but I'm also interested in whether this way of getting context is reliable and not going to cause any conflicts? I know you've said it's probably something we need to discuss...
I also know that we've literally just taken a similar approach for pulling in CSS styles via PHP, so our hands may be tied due to gutenberg not having the APIs available for us to utilise this information, but just checking how much you've looked into the react context approach at this point?
| } from '@wordpress/block-editor'; | ||
|
|
||
| const ColorControl = ( { value, onChange } ) => { | ||
| wp.data |
There was a problem hiding this comment.
please use import { dispatch } from "@wordpress/data" here
inc/class-loader.php
Outdated
| * Get the editor settings | ||
| */ | ||
| public function get_themer_editor_settings() { | ||
| $block_editor_context = new \WP_Block_Editor_Context( array() ); |
There was a problem hiding this comment.
Just had a convo on class usage on #13, based on that can you please change this to import the class at the top of the file and we can lose the \? Thanks!
I've not had a huge look into this but I should have some time to have a further look into it. @chrishbite Had suggested this way to me so not sure if he has anymore insight into this. |
|
This ticket is being closed due to its implementation not being compatible with the current refactor of the plugin. It's functionality will be included as part of this ticket: https://b5ecom.atlassian.net/browse/BBT-89 |
BBT-7
Converts CSS vars to hex values to be used in the colour components.
I've also brought in the block editor context as it was needed to get the colour pallets. Might want to bring this up for discussion how we do this as I assume it will be needed else where around the plugin.
Screenshots/Videos
http://bigbite.im/v/no4Fqn