build: Include exports for extending validator in JSR packaging #2114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2114 +/- ##
==========================================
+ Coverage 85.69% 89.81% +4.11%
==========================================
Files 91 42 -49
Lines 3782 3191 -591
Branches 1220 436 -784
==========================================
- Hits 3241 2866 -375
+ Misses 455 316 -139
+ Partials 86 9 -77 ☔ View full report in Codecov by Sentry. |
effigies
reviewed
Aug 28, 2024
| ".": "./src/bids-validator.ts", | ||
| "./main": "./src/main.ts", | ||
| "./output": "./src/utils/output.ts", | ||
| "./files": "./src/files/deno.ts", |
There was a problem hiding this comment.
Is there any chance we'd want to expose the browser files as well? Just thinking about backwards compatibility here.
There was a problem hiding this comment.
It is exported already via main. I think if we wanted to add browser features to the files API later, we would just point it at a new source file and re-export both.
|
Do you have a way to test this kind of thing without pushing to JSR, by the way? |
effigies
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These exports are used by OpenNeuro's CLI to extend the Deno validator.