Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use logger, not console, to log errors #2103

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

effigies
Copy link
Collaborator

Woops.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.77%. Comparing base (06df2f8) to head (b4d101e).
Report is 2 commits behind head on master.

Files Patch % Lines
bids-validator/src/schema/context.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2103      +/-   ##
==========================================
+ Coverage   85.69%   87.77%   +2.07%     
==========================================
  Files          91      133      +42     
  Lines        3782     6945    +3163     
  Branches     1220     1651     +431     
==========================================
+ Hits         3241     6096    +2855     
- Misses        455      754     +299     
- Partials       86       95       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit b2854b6 into bids-standard:master Aug 21, 2024
15 of 16 checks passed
@effigies effigies deleted the fix/logger-not-console branch August 21, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant