Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix jest tests that broke from earlier upgraes. #1705

Merged
merged 14 commits into from
Jun 30, 2023

Conversation

rwblair
Copy link
Member

@rwblair rwblair commented Jun 29, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.37 ⚠️

Comparison is base (c9b691e) 83.33% compared to head (53488db) 82.97%.

❗ Current head 53488db differs from pull request most recent head 9d6987c. Consider uploading reports for the commit 9d6987c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1705      +/-   ##
==========================================
- Coverage   83.33%   82.97%   -0.37%     
==========================================
  Files          92       92              
  Lines        3799     3142     -657     
  Branches     1171      713     -458     
==========================================
- Hits         3166     2607     -559     
+ Misses        535      437      -98     
  Partials       98       98              

see 63 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

.circleci/config.yml Outdated Show resolved Hide resolved
@effigies
Copy link
Collaborator

@rwblair Built the docker image locally and got it fixed up. Some small cleanups to ci. Pushed both to your branch, and I think this is good to go, if you want to have a quick look.

@rwblair rwblair merged commit 2ef75ac into bids-standard:master Jun 30, 2023
20 of 24 checks passed
@rwblair rwblair deleted the fix_symlink_tests branch June 30, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants