Bump hed-validator dependency to v3.9.0

[happy5214]

This version bundles the SCORE library schema and includes support for Onset and Offset tag validation.

[sappelhoff]

Thanks, the failure in the githubPagesTest seems to be related to HED, at first glance.

[happy5214]

It doesn't seem to like the instance variable declarations. Do you have a solution that doesn't involve a complete rewrite of the hed-validator classes? (Honestly, I'd rather learn TypeScript and rewrite the whole codebase in that than strip the classes of their instance variable declarations.)

[rwblair]

I may be able to fix this by upgrading the nextjs dependency for the site. Will push to this PR when I get something that works.

[sappelhoff]

I may be able to fix this by upgrading the nextjs dependency for the site. Will push to this PR when I get something that works.

is that related to

• Bump next from 11.1.3 to 12.1.0 #1422
• Migrate web site from Next to Vite #1430

?

[VisLab]

We'd really appreciate some help on this -- v 3.10.0 of the hed-validator has just been released -- supported partnered schema and there are some other key updates. Thanks!

[happy5214]

I just pushed an update to the package.json and package-lock.json to the PR.

[sappelhoff]

cc @nellh @rwblair

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (08f7c8d) 83.33% compared to head (fdde6c9) 83.33%.

❗ Current head fdde6c9 differs from pull request most recent head 280e6ab. Consider uploading reports for the commit 280e6ab to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1685   +/-   ##
=======================================
  Coverage   83.33%   83.33%           
=======================================
  Files          92       92           
  Lines        3799     3799           
  Branches     1171     1171           
=======================================
  Hits         3166     3166           
  Misses        535      535           
  Partials       98       98           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[rwblair]

I haven't been able to figure out why exactly the web build is broken. Once I clear away any commonjs directories that webpack is finding the web build errors become about babel plugins not being importable from parts of the validator code.

I have a partially working commit with nextjs upgraded, which requires webpack5. It also requires an upgraded react which requires some of our components to be fixed. I'm seeing this web build work ok in firefox but not in chrome:
https://github.com/rwblair/bids-validator/tree/bump-hed-validator-3.9.0

There are issues with the module reload used by nextjs. It doesn't play well with workspaces, its trying to load module.hot from bids-validator which isn't usable in the browser, but it also doesn't know to use import.meta.webpackHot instead which is provided. (And if we aren't going to have hot reloading of the validator in the web dev server maybe we should just switch to vite, with module reloading being the sticking point there.)

[rwblair]

@happy5214 @VisLab With the help of @nellh we got the web builds upgraded and working, along with the new hed-validator. Thank you for your patience.

[VisLab]

Thanks to all --- we appreciate the help!

…

On Thu, Jun 29, 2023 at 11:50 AM Ross Blair ***@***.***> wrote: Merged #1685 <#1685> into master. — Reply to this email directly, view it on GitHub <#1685 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJCJOQQHH5XZJFIZN7GJ6LXNWW3RANCNFSM6AAAAAAZGVJPFI> . You are receiving this because you were mentioned.Message ID: ***@***.***>