Line interception #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assert_equal [Geometry::Point[1,1]], line2.intersection(line1) | ||
| assert_equal [Geometry::Point[1,1]], line1.intersection(line2) | ||
| end | ||
| it "paralells lines shouldn't intercept" do |
There was a problem hiding this comment.
I think this should be 'intersect' instead of 'intercept'
|
Thanks. We're off to a good start. I have a few comments...
Thanks for taking care of this. It's almost ready to go. |
lib/geometry/line.rb
Outdated
| return [] | ||
| end | ||
|
|
||
| if object.vertical? || self.vertical? then |
bfoz
force-pushed
the
master
branch
2 times, most recently
from
d49c509
to
b8ddf0e
Compare
bfoz
force-pushed
the
master
branch
2 times, most recently
from
4e17e62
to
492c9db
Compare
|
Any reason this is not yet merged to master? Seems legit to me, and most certainly a useful feature. I am debating using this library for re-implementation of my laser-cutter gem, since I had to build my own geometry objects, but I'd rather use something more feature rich and well tested. |
|
Because I completely forgot about it 😳 Nice gem. Why do I feel like I've heard about it somewhere? Hackaday? |
bfoz
force-pushed
the
main
branch
3 times, most recently
from
b6f172d
to
0a3ca21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well ... this is my interception method. Whatever you think I should change just tell me.