Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attempt to deal with rounding issue when creating the swap chain #997

Merged
merged 4 commits into from
Dec 7, 2020
Merged

attempt to deal with rounding issue when creating the swap chain #997

merged 4 commits into from
Dec 7, 2020

Commits on Dec 7, 2020

  1. attempt to deal with rounding issue when creating the swap chain on h… 

    …igh DPI displays
    Nathan Jeffords committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    9a26b49 View commit details
    Browse the repository at this point in the history

  2. fix issues highlighted in review 

    * fix window size on creation
* rename `logical_width` & `logical_height` back to `width` & `height`
* update `Camera` trait to take width/height as `f32`
* update `WindowResized` to report 'f32' sizes instead if `u32`
* update `WindowCommand::SetResolution` to pass physical resolution instead of logical
* put `set_resolution` back, now taking `f32` instead of `u32`
* remove several unneeded `as f32`s now that `width` & `height` returns `f32`
    Nathan Jeffords committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    fdd6210 View commit details
    Browse the repository at this point in the history

  3. restore the return type of window's width and height function 

    * add back `logical_width` & `logical_height` so that code that wants full
  precision still has access, updated several places in engine that wanted
  `f32` to use these.
    Nathan Jeffords committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    0383151 View commit details
    Browse the repository at this point in the history

  4. revert argument types of Window::set_resolution method to u32

    Nathan Jeffords committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    5ab7184 View commit details
    Browse the repository at this point in the history