Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update input_toggle_active example #9913

Merged
merged 2 commits into from
Oct 28, 2023
Merged

docs: Update input_toggle_active example #9913

merged 2 commits into from
Oct 28, 2023

Conversation

ottah
Copy link
Contributor

@ottah ottah commented Sep 24, 2023 •
edited
Loading

Objective

  • Update incomplete example for bevy::input::common_conditions::input_toggle_active.

Solution

  • Update example.

@mockersf mockersf added the C-Docs An addition or correction to our documentation label Sep 25, 2023
@mockersf
Copy link
Member

this example is actually not using input_toggle_active, could you remove it from the imports? and it should show how to use input_just_pressed for that case instead of checking it in system

@mockersf mockersf added the A-Input Player input via keyboard, mouse, gamepad, and more label Sep 25, 2023
james7132
james7132 requested changes Oct 2, 2023
View reviewed changes
Copy link
Member

@james7132 james7132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an example intended to show how to use input_toggle_active. Doesn't removing it defeat the purpose of the example?

@mockersf
Copy link
Member

mockersf commented Oct 2, 2023 •
edited
Loading

It's just removing the import, the condition was actually never used in the test. From my understanding, this specific example is more "you can't use that condition if you need to move the state to your own resource/state/whatever"

@ottah ottah requested a review from james7132 October 5, 2023 01:56
@ottah
Copy link
Contributor Author

ottah commented Oct 25, 2023

@james7132 Can you take another look at this again with the added context from mockersf?

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 27, 2023
@james7132 james7132 added this pull request to the merge queue Oct 28, 2023
Merged via the queue into bevyengine:main with commit f48e685 Oct 28, 2023
22 checks passed
ameknite pushed a commit to ameknite/bevy that referenced this pull request Nov 6, 2023
@ottah @ameknite
docs: Update input_toggle_active example (bevyengine#9913)
0370a09 
# Objective

- Update incomplete example for
`bevy::input::common_conditions::input_toggle_active`.

## Solution

- Update example.
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@ottah
docs: Update input_toggle_active example (bevyengine#9913)
55c781d 
# Objective

- Update incomplete example for
`bevy::input::common_conditions::input_toggle_active`.

## Solution

- Update example.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rparrett rparrett rparrett approved these changes

@james7132 james7132 james7132 approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Input Player input via keyboard, mouse, gamepad, and more C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ottah @mockersf @rparrett @james7132 @alice-i-cecile