Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Update defaults for OrthographicProjection (#9537)" #9878

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Revert "Update defaults for OrthographicProjection (#9537)" #9878

merged 1 commit into from
Sep 20, 2023

Conversation

mnmaita
Copy link
Member

@mnmaita mnmaita commented Sep 20, 2023

Objective

Solution

  • Reverted commit 5012a0fd57748ab6f146776368b4cf988bba1eaa to restore the previous default values for OrthographicProjection.

Migration Guide

@mnmaita mnmaita added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Sep 20, 2023
@mnmaita mnmaita mentioned this pull request Sep 20, 2023
Closed
@alice-i-cecile alice-i-cecile added C-Breaking-Change A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Sep 20, 2023
@james7132 james7132 added this pull request to the merge queue Sep 20, 2023
@james7132 james7132 added this to the 0.12 milestone Sep 20, 2023
Merged via the queue into bevyengine:main with commit cd12605 Sep 20, 2023
26 checks passed
@mnmaita mnmaita deleted the revert-ortographic-projection-defaults branch September 20, 2023 21:24
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@mnmaita
Revert "Update defaults for OrthographicProjection (bevyengine#9537)" (…
071d564 
…bevyengine#9878)

# Objective

- Fixes bevyengine#9876

## Solution

- Reverted commit `5012a0fd57748ab6f146776368b4cf988bba1eaa` to restore
the previous default values for `OrthographicProjection`.

---

## Migration Guide

- Migration guide steps from bevyengine#9537 should be removed for next release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@IceSentry IceSentry IceSentry approved these changes

@tim-blackbird tim-blackbird tim-blackbird approved these changes

@DGriffin91 DGriffin91 DGriffin91 approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Breaking-Change A breaking change to Bevy's public API that needs to be noted in a migration guide C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.12
Development

Successfully merging this pull request may close these issues.

Revert change to default OrthographicProjection
6 participants
@mnmaita @alice-i-cecile @IceSentry @tim-blackbird @DGriffin91 @james7132