Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix animate_scale scaling z value in text2d example #9769

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Fix animate_scale scaling z value in text2d example #9769

merged 1 commit into from
Sep 13, 2023

Conversation

rparrett
Copy link
Contributor

Objective

I noticed this while testing #9733.

It's not causing any problems, but we shouldn't teach users to scale 2d stuff in z.

Solution

Only scale in x and y.

@rparrett rparrett added the C-Examples An addition or correction to our examples label Sep 11, 2023
@ickshonpe
Copy link
Contributor

ickshonpe commented Sep 11, 2023 •
edited
Loading

It's not causing any problems, but we shouldn't teach users to scale 2d stuff in z.

I only wish I could teach this to myself.

james7132
james7132 approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@james7132 james7132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does also make it easier to read too.

@james7132 james7132 added this pull request to the merge queue Sep 13, 2023
Merged via the queue into bevyengine:main with commit 8681d1c Sep 13, 2023
23 checks passed
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@rparrett
Fix animate_scale scaling z value in text2d example (bevyengine#9769)
f5843e7 
# Objective

I noticed this while testing bevyengine#9733.

It's not causing any problems, but we shouldn't teach users to scale 2d
stuff in z.

## Solution

Only scale in x and y.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@ickshonpe ickshonpe ickshonpe approved these changes

Assignees
No one assigned
Labels
C-Examples An addition or correction to our examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rparrett @ickshonpe @james7132