Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve various Debug implementations #9588

Merged
merged 4 commits into from
Aug 26, 2023

Conversation

JoJoJet
Copy link
Member

@JoJoJet JoJoJet commented Aug 26, 2023

Objective

  • Local and SystemName implement Debug manually, but they could derive it.
  • QueryState and dyn System have unconventional debug formatting.

@JoJoJet JoJoJet added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change labels Aug 26, 2023
@alice-i-cecile
Copy link
Member

This appears to duplicate the changes in #9581.

@alice-i-cecile
Copy link
Member

@ItsDoot, can I get your review over here :) This is closely related to your latest PR.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Aug 26, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Aug 26, 2023
Merged via the queue into bevyengine:main with commit e8b3892 Aug 26, 2023
24 checks passed
@JoJoJet JoJoJet deleted the better-debug branch August 26, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants