Added Val::ZERO Constant
#9566
Merged
Added Val::ZERO Constant
#9566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added `Val::ZERO` as a constant which is defined as `Val::Px(0.)`. * Added manual `PartialEq` implementation for `Val` which allows any zero value to equal any other zero value. E.g., `Val::Px(0.) == Val::Percent(0.)` etc. * Replaced instances of `Val::Px(0.)`, `Val::Percent(0.)`, etc. with `Val::ZERO` * Fixed `bevy_ui::layout::convert::tests::test_convert_from` test to account for Taffy not equating `Points(0.)` and `Percent(0.)`. These tests now use `assert_eq!(...)` instead of `assert!(matches!(...))` which gives easier to diagnose error messages.
Closed
|
CI Issues will be resolved by #9562 |
alice-i-cecile
added
A-UI
|
@jim-ec, want to toss a review on this for us? :) |
alice-i-cecile
approved these changes
Aug 25, 2023
jim-ec
approved these changes
Aug 25, 2023
|
Looks good to me. |
ickshonpe
suggested changes
Aug 25, 2023
alice-i-cecile
added
S-Ready-For-Final-Review
alice-i-cecile
added
the
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Val::Zero#9533Solution
Val::ZEROas a constant which is defined asVal::Px(0.).PartialEqimplementation forValwhich allows any zero value to equal any other zero value. E.g.,Val::Px(0.) == Val::Percent(0.)etc. This is technically a breaking change, asVal::Px(0.) == Val::Percent(0.)now equalstrueinstead offalse(as an example)Val::Px(0.),Val::Percent(0.), etc. withVal::ZERObevy_ui::layout::convert::tests::test_convert_fromtest to account for Taffy not equatingPoints(0.)andPercent(0.). These tests now useassert_eq!(...)instead ofassert!(matches!(...))which gives easier to diagnose error messages.