Improved text widget doc comments #9344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at a new `TextLayoutInfo` is generated on changes to `Text` and `Style`. While changes to those components may indirectly trigger a regeneration of the text layout, `text_system` itself only queries for changes to `Node` Also added details to `measure_text_system`'s doc comments explaining how it reacts to changes.
alice-i-cecile
added
C-Docs
alice-i-cecile
approved these changes
Aug 3, 2023
mockersf
reviewed
Aug 4, 2023
Co-authored-by: François <mockersf@gmail.com>
mockersf
approved these changes
Aug 4, 2023
mockersf
added
the
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The doc comment for
text_systemis not quite correct. It implies that a newTextLayoutInfois generated on changes toTextandStyle. While changes to those components might indirectly trigger a regeneration of the text layout,text_systemitself only queries for changes toNodeAlso added details to
measure_text_system's doc comments explaining how it reacts to changes.