Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve execution of examples in CI #9331

Merged
merged 6 commits into from
Aug 3, 2023

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Aug 1, 2023

Objective

  • Some examples crash in CI because of needing too many resources for the windows runner
  • Some examples have random results making it hard to compare screenshots

Solution

  • bloom_3d: reduce the number of spheres
  • pbr: use simpler spheres and reuse the mesh
  • tonemapping: use simpler spheres and reuse the mesh
  • shadow_biases: reduce the number of spheres
  • spotlight: use a seeded rng, move more cubes in view while reducing the total number of cubes, and reuse meshes and materials
  • external_source_external_thread, iter_combinations, parallel_query: use a seeded rng

Examples of errors encountered:

Caused by:
    In Device::create_bind_group
      note: label = `bloom_upsampling_bind_group`
    Not enough memory left
Caused by:
    In Queue::write_buffer
    Parent device is lost
ERROR wgpu_core::device::life: Mapping failed Device(Lost)

@mockersf mockersf added the C-Examples An addition or correction to our examples label Aug 1, 2023
@alice-i-cecile alice-i-cecile added A-Build-System Related to build systems or continuous integration A-Rendering Drawing game state to the screen labels Aug 1, 2023
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Aug 1, 2023
@alice-i-cecile
Copy link
Member

These all seem like reasonable, tiny changes in service of an important goal.

@mockersf mockersf force-pushed the example-friendlier-to-CI branch 3 times, most recently from c923003 to 2543322 Compare August 1, 2023 23:41
@alice-i-cecile
Copy link
Member

Merging as trivial.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Aug 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 3, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Aug 3, 2023
Merged via the queue into bevyengine:main with commit b6a2fc5 Aug 3, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Build-System Related to build systems or continuous integration A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants