Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-visible motion vector text in shader prepass example #9155

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Fix non-visible motion vector text in shader prepass example #9155

merged 1 commit into from
Aug 10, 2023

Conversation

ShadowMitia
Copy link
Contributor

Objective

In the shader prepass example, changing to the motion vector output hides the text, because both it and the background are rendererd black.
Seems to have been caused by this commit? 71cf35c

Solution

Make the text white on all outputs.

@Selene-Amanita Selene-Amanita added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples labels Jul 15, 2023
@Selene-Amanita Selene-Amanita added this to the 0.11.1 milestone Jul 15, 2023
@james7132 james7132 requested a review from IceSentry July 15, 2023 21:23
IceSentry
IceSentry approved these changes Jul 16, 2023
View reviewed changes
Copy link
Contributor

@IceSentry IceSentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JMS55 do you remember why you wanted the motion vectors to have black text?

@JMS55
Copy link
Contributor

JMS55 commented Jul 16, 2023

I'm guessing it was because motion vectors used to use a yellow background, instead of white.

@ShadowMitia ShadowMitia requested a review from JMS55 August 8, 2023 17:29
@cart cart added this pull request to the merge queue Aug 10, 2023
Merged via the queue into bevyengine:main with commit b8695d0 Aug 10, 2023
20 checks passed
cart pushed a commit that referenced this pull request Aug 10, 2023
@ShadowMitia @cart
Fix non-visible motion vector text in shader prepass example (#9155)
c4edbdb 
# Objective

In the shader prepass example, changing to the motion vector output
hides the text, because both it and the background are rendererd black.
Seems to have been caused by this commit?
71cf35c

## Solution

Make the text white on all outputs.
@ShadowMitia ShadowMitia deleted the fix-shader-prepass-example branch August 10, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cart cart cart approved these changes

@IceSentry IceSentry IceSentry approved these changes

@JMS55 JMS55 JMS55 approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples
Projects
None yet
Milestone
0.11.1
Development

Successfully merging this pull request may close these issues.
5 participants
@ShadowMitia @JMS55 @cart @IceSentry @Selene-Amanita