Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use ViewNodeRunner in the post_processing example #9127

Merged
merged 3 commits into from
Aug 7, 2023
Merged

use ViewNodeRunner in the post_processing example #9127

merged 3 commits into from
Aug 7, 2023

Conversation

IceSentry
Copy link
Contributor

Objective

  • I forgot to update the example after the ViewNodeRunner was merged. It was even partially mentioned in one of the comments.

Solution

  • Use the ViewNodeRunner in the post_processing example
  • I also broke up a few lines that were a bit long

@IceSentry IceSentry added A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples labels Jul 12, 2023
@james7132 james7132 added this to the 0.11.1 milestone Aug 3, 2023
JMS55
JMS55 suggested changes Aug 4, 2023
View reviewed changes
examples/shader/post_processing.rs Outdated Show resolved Hide resolved
examples/shader/post_processing.rs Outdated Show resolved Hide resolved
examples/shader/post_processing.rs Outdated Show resolved Hide resolved
IceSentry and others added 2 commits August 4, 2023 00:28
@IceSentry @JMS55
Apply suggestions from code review
0208c6f 
Co-authored-by: JMS55 <47158642+JMS55@users.noreply.github.com>
@IceSentry
clean up
5a48d7e
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Aug 6, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Aug 7, 2023
Merged via the queue into bevyengine:main with commit 171ff1b Aug 7, 2023
21 checks passed
cart pushed a commit that referenced this pull request Aug 10, 2023
@IceSentry @JMS55 @cart
use ViewNodeRunner in the post_processing example (#9127)
2a02929 
- I forgot to update the example after the `ViewNodeRunner` was merged.
It was even partially mentioned in one of the comments.

- Use the `ViewNodeRunner` in the post_processing example
- I also broke up a few lines that were a bit long

---------

Co-authored-by: JMS55 <47158642+JMS55@users.noreply.github.com>
@IceSentry IceSentry deleted the post-processing-view-node branch August 30, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@mockersf mockersf mockersf approved these changes

@JMS55 JMS55 JMS55 approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.11.1
Development

Successfully merging this pull request may close these issues.
5 participants
@IceSentry @james7132 @mockersf @JMS55 @alice-i-cecile