UI extraction order fix #9099
Merged
UI extraction order fix #9099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added the `ExtractAtlasNode` variant to `RenderUiSystem`. * Changed `ExtractSchedule` so that `extract_uinode_borders` and `extract_text_uinodes` run after `extract_atlas_uinodes`.
Selene-Amanita
added
C-Bug
cart
approved these changes
Jul 14, 2023
james7132
approved these changes
Jul 15, 2023
| extract_uinode_borders.after(RenderUiSystem::ExtractNode), | ||
| extract_atlas_uinodes | ||
| .in_set(RenderUiSystem::ExtractAtlasNode) | ||
| .after(RenderUiSystem::ExtractNode), |
There was a problem hiding this comment.
It may be preferable to order the sets relative to each other, over ordering the individual system against it.
This is strictly non-blocking, and this works as-is.
james7132
added
the
S-Ready-For-Final-Review
mockersf
approved these changes
Jul 23, 2023
cart
pushed a commit
that referenced
this pull request
Aug 10, 2023
# Objective Fixes #9097 ## Solution Reorder the `ExtractSchedule` so that the `extract_text_uinodes` and `extract_uinode_borders` systems are run after `extract_atlas_uinodes`. ## Changelog `bevy_ui::render`: * Added the `ExtractAtlasNode` variant to `RenderUiSystem`. * Changed `ExtractSchedule` so that `extract_uinode_borders` and `extract_text_uinodes` run after `extract_atlas_uinodes`.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #9097
Solution
Reorder the
ExtractScheduleso that theextract_text_uinodesandextract_uinode_borderssystems are run afterextract_atlas_uinodes.Changelog
bevy_ui::render:ExtractAtlasNodevariant toRenderUiSystem.ExtractScheduleso thatextract_uinode_bordersandextract_text_uinodesrun afterextract_atlas_uinodes.