Fix gizmo line width issue when using perspective #9067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceSentry
changed the title
IceSentry
added
C-Bug
nicopap
approved these changes
Jul 18, 2023
mockersf
approved these changes
Jul 31, 2023
mockersf
added
the
S-Ready-For-Final-Review
alice-i-cecile
approved these changes
Jul 31, 2023
cart
pushed a commit
that referenced
this pull request
Aug 10, 2023
- In bevy_polyline, we discovered an issue that happens when line width is smaller than 1.0 and using perspective. It would sometimes end up negative or NaN. I'm not entirely sure _why_ it happens. - Make sure the width doesn't go below 0 before multiplying it with the alpha Here's a link to the bevy_polyline issue ForesightMiningSoftwareCorporation/bevy_polyline#46 I'm not sure if the solution is correct but it solved the issue in my testing. Co-authored-by: François <mockersf@gmail.com>
43 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Notes
Here's a link to the bevy_polyline issue ForesightMiningSoftwareCorporation/bevy_polyline#46
I'm not sure if the solution is correct but it solved the issue in my testing.