Use a consistent seed for AABB gizmo colors #9030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, the same entities bounding box will have the same color between runs. The random number was chose so that the first few colors are clearly distinct.
nicopap
added
C-Enhancement
tim-blackbird
approved these changes
Jul 3, 2023
IceSentry
approved these changes
Jul 3, 2023
nicopap
added
the
S-Ready-For-Final-Review
mockersf
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The bounding box colors are from bevy_gizmo are randomized between app runs. This can get confusing for users.
Solution
Use a fixed seed with
RandomState::with_seedsrather than initializing aAHash.The random number was chose so that the first few colors are clearly distinct.
According to the
RandomState::hash_onedocumentation, it's also faster.Changelog