Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #8975 -- Add return to RenderDevice::poll() #8977

Merged
merged 3 commits into from
Jun 28, 2023
Merged

Refs #8975 -- Add return to RenderDevice::poll() #8977

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90af811
add return value to RenderDevice::poll()
Skovrup1 Jun 27, 2023
e72f834
Comment detailing the return value
Skovrup1 Jun 27, 2023
06136c2
Incorrect reference to Queue in comment on return
Skovrup1 Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions crates/bevy_render/src/renderer/render_device.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,16 @@ impl RenderDevice {

/// Check for resource cleanups and mapping callbacks.
///
/// Return `true` if the queue is empty, or `false` if there are more queue
/// submissions still in flight. (Note that, unless access to the [`wgpu::Queue`] is
/// coordinated somehow, this information could be out of date by the time
/// the caller receives it. `Queue`s can be shared between threads, so
/// other threads could submit new work at any time.)
///
/// no-op on the web, device is automatically polled.
alice-i-cecile marked this conversation as resolved.
Show resolved Hide resolved
#[inline]
pub fn poll(&self, maintain: wgpu::Maintain) {
self.device.poll(maintain);
pub fn poll(&self, maintain: wgpu::Maintain) -> bool {
self.device.poll(maintain)
}

/// Creates an empty [`CommandEncoder`](wgpu::CommandEncoder).
Expand Down