Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow unsized types as mapped value in Ref::map #8817

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Allow unsized types as mapped value in Ref::map #8817

merged 1 commit into from
Jun 12, 2023

Conversation

nicopap
Copy link
Contributor

@nicopap nicopap commented Jun 11, 2023

Objective

  • I can't map unsized type using Ref::map (for example dyn Reflect)

Solution

  • Allow unsized types (this is possible because Ref stores a reference to T)

@nicopap nicopap added C-Bug An unexpected or incorrect behavior A-ECS Entities, components, systems, and events C-Usability A simple quality-of-life change that makes Bevy easier to use labels Jun 11, 2023
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jun 11, 2023
@james7132 james7132 added this pull request to the merge queue Jun 12, 2023
Merged via the queue into bevyengine:main with commit ea887d8 Jun 12, 2023
@nicopap nicopap deleted the fix_ref_map branch August 30, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicopap @james7132 @alice-i-cecile