Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document every public item in bevy_ecs #8731

Merged
merged 65 commits into from
Jun 10, 2023
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
cba8a45
add docs to Access structs
JoJoJet May 31, 2023
eb3e2e7
add docs to ParIter
JoJoJet May 31, 2023
28ba325
add docs to QueryState methods
JoJoJet May 31, 2023
b532943
add missing docs to condition.rs
JoJoJet May 31, 2023
0f647af
add missing docs to `SystemConfig`/`s`
JoJoJet May 31, 2023
210bbb0
add missing docs to `NodeId` variants
JoJoJet May 31, 2023
e82f1ef
add missing docs to `new` functions for schedules
JoJoJet May 31, 2023
efb8eb9
add docs to `States::Iter`
JoJoJet May 31, 2023
34eeb15
add missing docs for system sets
JoJoJet May 31, 2023
3978b66
add docs to `SparseSetIndex`
JoJoJet May 31, 2023
4c3f980
add docs to `CombinatorSystem`
JoJoJet May 31, 2023
8f1481f
add docs to `ParallelCommands::command_scope`
JoJoJet May 31, 2023
85ee513
add docs to system marker types
JoJoJet May 31, 2023
6ab8119
add docs to `System::apply_buffers`
JoJoJet May 31, 2023
bb8d299
add docs to `IntoSystem::system`
JoJoJet May 31, 2023
a9cd743
add docs to `SystemName`
JoJoJet May 31, 2023
0895efd
add docs to `SystemState`
JoJoJet May 31, 2023
aa194f6
add missing docs to `Archetype`
JoJoJet May 31, 2023
3875e1a
add missing docs to `bundle.rs`
JoJoJet May 31, 2023
da6683d
add missing docs to change detection methods
JoJoJet May 31, 2023
7421b1e
Merge remote-tracking branch 'upstream/main' into ecs-docs
JoJoJet May 31, 2023
e03a0fd
add missing docs to commands
JoJoJet May 31, 2023
eead342
add missing docs to system params
JoJoJet May 31, 2023
e37bffd
add docs to `check_change_tick`
JoJoJet May 31, 2023
c97c067
document `SystemState::new`
JoJoJet May 31, 2023
a29c867
document executor constructors
JoJoJet May 31, 2023
14ed693
add missing docs to `WorldQuery`
JoJoJet May 31, 2023
206b7f5
document `archetype_components_len`
JoJoJet May 31, 2023
5e0f339
publicly document `Entities::flush_as_invalid`
JoJoJet May 31, 2023
578c3ca
add missing docs to `entity_ref.rs`
JoJoJet May 31, 2023
3f64496
document world modules
JoJoJet May 31, 2023
3a43ebb
add missing docs to world methods
JoJoJet May 31, 2023
c15e992
add missing docs to `SpawnBatchIter`
JoJoJet May 31, 2023
edf776e
add missing docs to `unsafe_world_cell.rs`
JoJoJet May 31, 2023
2c2bb08
add missing docs to `WorldCell`
JoJoJet May 31, 2023
35db910
add missing docs to `component.rs`
JoJoJet May 31, 2023
5ea50f2
add missing docs to event.rs
JoJoJet May 31, 2023
07d73ff
document top-level modules
JoJoJet May 31, 2023
2ec8f7c
add missing docs for `RemovedComponents`
JoJoJet May 31, 2023
d511301
add missing docs to `ReflectMapEntities`
JoJoJet May 31, 2023
b34abc3
warn on missing docs
JoJoJet May 31, 2023
94ed960
Fix ape-brain comments
JoJoJet May 31, 2023
3fd9d3d
remove a reference to a private function
JoJoJet May 31, 2023
4364e08
Apply suggestions from code review
JoJoJet Jun 2, 2023
912c737
Rewrite docs for `Bundles`
JoJoJet Jun 2, 2023
86d747a
Merge remote-tracking branch 'upstream/main' into ecs-docs
JoJoJet Jun 2, 2023
ca47a6a
Apply suggestions from code review
JoJoJet Jun 2, 2023
cc3c824
Clarify when `Bundles::get` returns `None`
JoJoJet Jun 2, 2023
6ffa2c9
Tweak docs for `Ref::into_inner`
JoJoJet Jun 2, 2023
96099b8
rewrite docs for `Archetypes::generation`
JoJoJet Jun 3, 2023
d3f847c
`apply_buffers` -> `apply_deferred`
JoJoJet Jun 3, 2023
012c1fe
qualify a type in docs
JoJoJet Jun 3, 2023
3d0ab51
use different syntax to qualify a doc link
JoJoJet Jun 3, 2023
c68f9dc
Fix a typo
JoJoJet Jun 3, 2023
31b5021
Make some phrasing more general
JoJoJet Jun 3, 2023
8c6ada9
Tweak documentation for Components metadata functions
JoJoJet Jun 3, 2023
a23d102
tweak docs for `validate_world`
JoJoJet Jun 3, 2023
9faf035
variants
JoJoJet Jun 3, 2023
8b7d4e7
Merge remote-tracking branch 'upstream/main' into ecs-docs
JoJoJet Jun 3, 2023
5213b1c
Merge remote-tracking branch 'upstream/main' into ecs-docs
JoJoJet Jun 8, 2023
39ac5c7
rewrite docs for `QueryState::get_manual`
JoJoJet Jun 8, 2023
5aa7b0f
ComponentId is not opaque
JoJoJet Jun 8, 2023
94b3a2d
Option -> Result
JoJoJet Jun 9, 2023
e5c2284
ComponentId::new
JoJoJet Jun 9, 2023
ebc14e9
doc links
JoJoJet Jun 9, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/bevy_ecs/src/component.rs
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ impl ComponentInfo {
}
}

/// A semi-opaque value which uniquely identifies the type of a [`Component`] within a
/// A value which uniquely identifies the type of a [`Component`] within a
/// [`World`](crate::world::World).
///
/// Each time a new `Component` type is registered within a `World` using
Expand Down
11 changes: 8 additions & 3 deletions crates/bevy_ecs/src/query/state.rs
Original file line number Diff line number Diff line change
Expand Up @@ -344,9 +344,14 @@ impl<Q: WorldQuery, F: ReadOnlyWorldQuery> QueryState<Q, F> {
}

/// Gets the query result for the given [`World`] and [`Entity`].
/// This will only work for archetypes that this [`QueryState`] has in its cache.
/// To ensure that the cache is up to date, call [`QueryState::update_archetypes`].
/// Alternatively, call [`QueryState::get`] instead, which calls `update_archetypes` for you.
///
/// This method is slightly more efficient than [`QueryState::get`] in some situations, since
/// it does not update this instance's internal cache. This method will return `None` if `entity`
JoJoJet marked this conversation as resolved.
Show resolved Hide resolved
/// belongs to an archetype that has not been cached.
///
/// To ensure that the cache is up to date, call [`QueryState::update_archetypes`] before this method.
/// The cache is also updated in [`QueryState::new`], `QueryState::get`, or any method with mutable
/// access to `self`.
///
/// This can only be called for read-only queries, see [`Self::get_mut`] for mutable queries.
#[inline]
Expand Down