Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TextureAtlas::texture_handles pub instead of pub(crate) (#8633) #8643

Merged
merged 1 commit into from
May 21, 2023
Merged

Make TextureAtlas::texture_handles pub instead of pub(crate) (#8633) #8643

merged 1 commit into from
May 21, 2023

Conversation

adtennant
Copy link
Contributor

Objective

Solution

Make TextureAtlas::texture_handles pub instead of pub(crate).

@adtennant
Make TextureAtlas::texture_handles pub instead of pub(crate) (b…
70cf676 
…evyengine#8633)

# Objective

- Fixes bevyengine#8633

## Solution

Make `TextureAtlas::texture_handles` `pub` instead of `pub(crate)`.
@github-actions
Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Usability A simple quality-of-life change that makes Bevy easier to use labels May 20, 2023
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 20, 2023
james7132
james7132 approved these changes May 21, 2023
View reviewed changes
Copy link
Member

@james7132 james7132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why #7858 made this pub(crate). That PR should have been marked breaking.

@james7132 james7132 added this pull request to the merge queue May 21, 2023
Merged via the queue into bevyengine:main with commit fdec72b May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@nicopap nicopap nicopap approved these changes

@ickshonpe ickshonpe ickshonpe approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The field texture_handles in TextureAtlas changed visibility making the struct non instantiable from Game Code
5 participants
@adtennant @james7132 @alice-i-cecile @nicopap @ickshonpe