Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bevy_render: delegate buffer aligning to RenderResourceContext #842

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

mrk-its
Copy link
Member

@mrk-its mrk-its commented Nov 11, 2020

WebGL2 has different uniform / texture aligning requirements than wgpu. This PR moves uniform / texture aligning code to RenderResourceContext. Current aligning behaviour for wgpu should be preserved.

@memoryruins memoryruins added the A-Rendering Drawing game state to the screen label Nov 11, 2020
@@ -482,23 +479,6 @@ fn render_resources_node_system<T: RenderResources>(
state
.uniform_buffer_arrays
.copy_staging_buffer_to_final_buffers(&mut state.command_queue, staging_buffer);
} else {
// TODO: can we just remove this?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems it can be safely removed, tested a lot of bevy examples without it and everything seems to work.

@cart
Copy link
Member

cart commented Nov 11, 2020

Looks good to me!

@cart cart merged commit fae6287 into bevyengine:master Nov 11, 2020
@ambeeeeee ambeeeeee mentioned this pull request Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants