Fix panics and docs when using World schedules #8364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoJoJet
added
C-Bug
tim-blackbird
approved these changes
Apr 12, 2023
JoJoJet
changed the title
try_run_schedule
|
I fixed a couple more related issues that I noticed. |
cart
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The method
World::try_run_schedulecurrently panics if theSchedulesresource does not exist, but it should just return anErr. Similarly,World::add_schedulepanics unnecessarily if the resource does not exist.Also, the documentation for
World::add_scheduleis completely wrong.Solution
When the
Schedulesresource does not exist, we now treat it the same as if it did exist but was empty. When callingadd_schedule, we initialize it if it does not exist.